Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong field recipient_key instead of recipient_did in delivery message in Pickup V3 protocol #23

Open
antonbaliasnikov opened this issue Aug 3, 2023 · 1 comment

Comments

@antonbaliasnikov
Copy link

Bug overview

Accordingly to https://didcomm.org/pickup/3.0/ protocol, the https://didcomm.org/messagepickup/3.0/delivery response should have a field named recipient_did in the response body:

{
    "id": "123456780",
    "thid": "<message id of delivery-request message>",
    "type": "https://didcomm.org/messagepickup/3.0/delivery",
    "body": {
        "recipient_did": "<did for messages>"
    },
    "attachments": [{
        "id": "<id of message>",
        "data": {
            "base64": "<message>"
        }
    }]
}

But the RootsID mediator returns the field named recipient_key instead. An example of a response:

{
    "id": "e1840d83-3333-4a18-94e5-d2070ae4c40e",
    "typ": "application\/didcomm-plain+json",
    "type": "https://didcomm.org/messagepickup/3.0/status",
    "body": {
        "live_delivery": false,
        "recipient_key": "did:peer:...",
        "message_count": 0
    }
}

Expected behavior

The recipient_key field in the body response should be named recipient_did accordingly to the protocol description.

@rodolfomiranda
Copy link
Contributor

Thanks @antonbaliasnikov . We haven't update the code with the latest updates in the spec. We'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants