Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] document configuring server for multi-compiler #1713

Closed
kellymears opened this issue Sep 25, 2022 · 0 comments
Closed

[docs] document configuring server for multi-compiler #1713

kellymears opened this issue Sep 25, 2022 · 0 comments
Labels

Comments

@kellymears
Copy link
Member

The reproduction case provided in #1702 calls .serve, .watch and .proxy from within the context of a child instance.

Anything related to the development server should be called only within the context of the parent instance.

This isn't really documented, but it should be documented here.

Demo

This is incorrect:

export default async bud => {
  await bud.make(`app`, async app =>
    app
      .watch([`resources/views/**/*`, `app/**/*`])
      .proxy(`https://sage.test`)
      .serve(`http://0.0.0.0:3000`)
  )

  await bud.make(`editor`, async editor => editor)
}

This is correct:

export default async bud => {
  bud
    .watch([`resources/views/**/*`, `app/**/*`])
    .proxy(`https://sage.test`)
    .serve(`http://0.0.0.0:3000`);

  await bud.make(`app`, async app => app)
  await bud.make(`editor`, async editor => editor)
}
kodiakhq bot pushed a commit that referenced this issue Sep 28, 2022
- release notes for 6.4.4
- new tag page component
- update `/blog/*` -> `/release/*` (included in redirects)
- add documentation on configuring server in multi-instance config (see #1713)

refers:

- #1713

## Type of change

**PATCH: backwards compatible change**



This PR includes breaking changes to the following core packages:

- none

This PR includes breaking changes to the follow extensions:

- none

## Dependencies

### Adds

- none

### Removes

- none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant