Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] @roots/bud-vue: ?inline query parameter breaks build #2518

Closed
3 tasks done
kellymears opened this issue Dec 12, 2023 · 0 comments · Fixed by #2519
Closed
3 tasks done

[bug] @roots/bud-vue: ?inline query parameter breaks build #2518

kellymears opened this issue Dec 12, 2023 · 0 comments · Fixed by #2519
Assignees
Labels
bug Something isn't working

Comments

@kellymears
Copy link
Member

Agreement

Describe the issue

After installing @roots/bud-vue, if using ?inline query parameter in a stylesheet, the build will break.

Expected Behavior

The asset will be inlined in the stylesheet

Actual Behavior

The build breaks

Steps To Reproduce

  1. Install @roots/bud-vue
  2. Install a compatible transformer: @roots/bud-babel, @roots/bud-swc, or @roots/bud-typescript
  3. Reference an asset in a index.scss using the ?inline parameter. Example: background-image: url(~@src/example.svg?inline);
  4. Run bud build production

version

6.18.0

Logs

No response

Configuration

No response

Relevant .budfiles

No response

@kellymears kellymears added the bug Something isn't working label Dec 12, 2023
@kellymears kellymears self-assigned this Dec 12, 2023
kellymears added a commit that referenced this issue Dec 12, 2023
@kodiakhq kodiakhq bot closed this as completed in #2519 Dec 12, 2023
kodiakhq bot pushed a commit that referenced this issue Dec 12, 2023
- Fixes #2518 by setting up asset/resources and asset/inline rules before the main `oneOf` group, each in their own `ownOf` ruleset.
- Simplifies `@roots/bud-vue`, which doesn't need to handle this exceptionally any longer
- Adds an integration test specifically targeting this to prevent regressions

Whoops, this also bumps us up to yarn v4. I thought I branched that before committing but we want to do this anyway, for sure.

## Type of change

**MINOR: feature**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant