Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] bud-sass/stylelint-config in incompatible with WP naming #2538

Closed
3 tasks done
cawa-93 opened this issue Jan 3, 2024 · 2 comments · Fixed by #2539
Closed
3 tasks done

[bug] bud-sass/stylelint-config in incompatible with WP naming #2538

cawa-93 opened this issue Jan 3, 2024 · 2 comments · Fixed by #2539
Labels
bug Something isn't working

Comments

@cawa-93
Copy link
Contributor

cawa-93 commented Jan 3, 2024

Agreement

Describe the issue

Connecting a @roots/bud-sass/stylelint-config causes the stylelint to identify the WP custom properties as having incorrect names

Expected custom property name "--wp-admin--admin-bar--height" to be kebab-case  custom-property-pattern

Expected Behavior

@roots/bud-sass/stylelint-config contains configuration changes to take into account the WP naming

Actual Behavior

Stylelint throw error on each WP-defined custom property.

Steps To Reproduce

Use --wp-admin--admin-bar--height in scss file and lint it

version

6.20.1

Logs

No response

Configuration

No response

Relevant .budfiles

No response

@kellymears
Copy link
Member

This rule is nulled in @roots/bud-preset-wordpress/config/stylelint, so you should be able to add that config to your extends array.

I have some questions about your regular expression in your PR but I'm not averse to being more specific with the rule rather than outright disabling it.

@cawa-93
Copy link
Contributor Author

cawa-93 commented Jan 4, 2024

This rule is nulled in @roots/bud-preset-wordpress/config/stylelint, so you should be able to add that config to your extends array.

Oh, I see. I'm new to the roots ecosystem and that's why I was confused by this, because @roots/bud-preset-wordpress/config/stylelint was not mentioned in the bud documentation or sage documentation. This led me to believe that everything wp-specific is already inside @roots/sage/stylelint

@kodiakhq kodiakhq bot closed this as completed in #2539 Jan 9, 2024
kodiakhq bot pushed a commit that referenced this issue Jan 9, 2024
…ng (#2539)

## Type of change

**MAJOR: breaking change**
fix #2538
kodiakhq bot pushed a commit that referenced this issue Jan 19, 2024
Mention `@roots/bud-preset-wordpress/stylelint` export.

- Fixes: #2542
- See also: #2538

## Type of change

**NONE: internal change**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants