Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: @roots/bud-react #1104

Merged
merged 6 commits into from Feb 8, 2022
Merged

improve: @roots/bud-react #1104

merged 6 commits into from Feb 8, 2022

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented Feb 5, 2022

Overview

  • disables react-refresh-webpack-plugin as a default
  • improves typings for bud.reactRefresh function
  • makes bud.reactRefresh idempotent
    • disabling react-refresh-webpack-plugin will also remove the react-refresh client script in addition to the extension
  • adds exports for @roots/bud-react/extension
  • defines in @roots/bud-framework what an EntryObject is
  • types bud.entry against that definition
  • types Framework.Hooks against that definition
  • types bud.reactRefresh entry reducers against that definition
  • adds exports for:
    • @roots/bud-react/extension
    • @roots/bud-react/react-refresh
    • @roots/bud-react/react-refresh/*
    • @roots/bud-api/methods/*

refers: none
closes: none

Type of change

  • PATCH: Backwards compatible bug fix

This PR includes breaking changes to the following core packages:

  • none

This PR includes breaking changes to the follow extensions:

  • none

Dependency changes

  • none

Todo

  • covered by unit and/or integration tests
  • include documentation updates
  • featured in the changelog

@kellymears kellymears merged commit f567254 into main Feb 8, 2022
@kellymears kellymears deleted the fix-react-refresh branch February 8, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant