Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: bud.config #1287

Merged
merged 1 commit into from
Mar 22, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions sources/@roots/bud-api/src/api/methods/config/index.ts
Original file line number Diff line number Diff line change
@@ -1,24 +1,32 @@
import type {Framework} from '@roots/bud-framework'
import Webpack from 'webpack'
import {lodash} from '@roots/bud-support'
import {Configuration} from 'webpack'

const {isFunction} = lodash

export interface override {
(config: Partial<Configuration>): Partial<Configuration>
}

export interface config {
(overrides: Partial<Webpack.Configuration>): Framework
(input: override | Partial<Configuration>): Framework
}

export function config(
overrides: (
config: Partial<Webpack.Configuration>,
) => Partial<Webpack.Configuration>,
): Framework {
export const config: config = function (input): Framework {
const ctx = this as Framework

if (!overrides)
if (!input)
throw new Error(
'config overrides must pass a callback function that returns a webpack configuration',
'config input must pass a callback function that returns a webpack configuration',
)

ctx.hooks.action('event.build.after', async app => {
app.build.config = overrides(app.build.config)
app.build.config = isFunction(input)
? input(app.build.config)
: {
...app.build.config,
...input,
}
})

return ctx
Expand Down