Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 fix(patch): instantiate nested extensions #1411

Merged
merged 7 commits into from
May 15, 2022
Merged

🚑 fix(patch): instantiate nested extensions #1411

merged 7 commits into from
May 15, 2022

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented May 15, 2022

This PR fixes a potentially critical issue and should be released on an immediate basis as 5.8.2.

Overview

Fixes an error in 5.8 which can cause nested extensions to not be instantiated.

I experienced this behavior when using @roots/bud-sass and @roots/bud-tailwindcss together.

Critical changes:

  • Adds conditional recursive call to bud.extensions.import to instantiate missing extensions regardless of how the extension was added.
  • Adds an integration test for @roots/bud-sass and @roots/bud-tailwindcss being used together.

Secondary:

  • Introduces change to app.project that omits env variables from project.json reportage.

Changes

  • 🚑 fix(patch): instantiate nested extensions
  • 🐛 fix(none): extensions review
  • 🐛 fix(none): core review
  • 🧪 test(none): add sass-tailwindcss integration test
  • 🧪 test(none): unit tests
  • 🛼 improve(patch): omit env variables from project.json reporting
  • 📦 deps(none): yarn.lock

refers: none
closes: none

Type of change

  • PATCH: Backwards compatible bug fix

This PR includes breaking changes to the following core packages:

  • none

This PR includes breaking changes to the follow extensions:

  • none

Dependencies

Adds

  • none

Removes

  • none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant