Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure process exit code is set on compilation error #1985

Merged
merged 7 commits into from
Jan 5, 2023
Merged

fix: ensure process exit code is set on compilation error #1985

merged 7 commits into from
Jan 5, 2023

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented Jan 5, 2023 •
edited by retlehs
Loading

  • ensure sure process exit code is set to 1 even if an error is not explicitly thrown by the compiler

refers:

Type of change

PATCH: backwards compatible change

This PR includes breaking changes to the following core packages:

  • none

This PR includes breaking changes to the follow extensions:

  • none

Dependencies

Adds

  • none

Removes

  • none

@github-actions github-actions bot added config dependencies Pull requests that update a dependency file labels Jan 5, 2023
@kellymears kellymears linked an issue Jan 5, 2023 that may be closed by this pull request
[bug] Bud returns "0" exit code when the build errors #1986
Closed
@kellymears kellymears added the 🚀! automerge label Jan 5, 2023
@kodiakhq kodiakhq bot merged commit 0214f5e into main Jan 5, 2023
@kodiakhq kodiakhq bot deleted the process-error branch January 5, 2023 20:55
@kellymears kellymears added this to the 6.7.0 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
config dependencies Pull requests that update a dependency file @roots/bud @roots/bud-compiler test 🚀! automerge
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.

[bug] Bud returns "0" exit code when the build errors
1 participant
@kellymears