Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ improve(@roots/bud): remove extraneous peer dependencies #2243

Merged
merged 1 commit into from
May 9, 2023
Merged

✨ improve(@roots/bud): remove extraneous peer dependencies #2243

merged 1 commit into from
May 9, 2023

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented May 1, 2023 •
edited
Loading

With this change pnpm users can install bud with limited hoisting and no .pnpmfile required:

pnpm install --public-hoist-pattern="@roots/*"

Changes

  • Remove extraneous peer dependencies from all packages defining them
  • Import bind from @roots/bud-support/decorators/bind directly
  • @roots/bud-compiler: resolve webpack using bud.module before import.
  • @roots/bud-emotion: add missing dependencies
  • @roots/bud-purgecss: use Extension class
  • @roots/bud-purgecss: add missing dependencies

Type of change

MINOR: feature

@kellymears kellymears self-assigned this May 1, 2023
@kellymears kellymears added this to the 6.13.0 milestone May 1, 2023
@kellymears kellymears added the 🚀! automerge label May 9, 2023
@kodiakhq kodiakhq bot merged commit 9c8af5f into main May 9, 2023
8 checks passed
@kodiakhq kodiakhq bot deleted the pnpm-fix-peers branch May 9, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kellymears kellymears

Labels
dependencies Pull requests that update a dependency file @roots/blade-loader @roots/browserslist-config @roots/bud @roots/bud-api @roots/bud-babel @roots/bud-build @roots/bud-cache @roots/bud-client @roots/bud-compiler @roots/bud-compress @roots/bud-criticalcss @roots/bud-dashboard @roots/bud-emotion @roots/bud-entrypoints @roots/bud-esbuild @roots/bud-eslint @roots/bud-extensions @roots/bud-framework @roots/bud-hooks @roots/bud-preset-recommend @roots/bud-preset-wordpress @roots/bud-prettier @roots/bud-purgecss @roots/bud-react @roots/bud-sass @roots/bud-server @roots/bud-solid @roots/bud-stylelint @roots/bud-support @roots/bud-swc @roots/bud-tailwindcss @roots/bud-tailwindcss-theme-json @roots/bud-terser @roots/bud-typescript @roots/bud-wordpress-dependencies @roots/bud-wordpress-externals @roots/bud-wordpress-manifests @roots/bud-wordpress-theme-json @roots/critical-css-webpack-plugin @roots/dependencies @roots/entrypoints-webpack-plugin @roots/eslint-config @roots/filesystem @roots/merged-manifest-webpack-plugin @roots/sage @roots/wordpress-dependencies-webpack-plugin @roots/wordpress-externals-webpack-plugin @roots/wordpress-hmr @roots/wordpress-theme-json-webpack-plugin test 🚀! automerge
Projects
None yet
Milestone
6.13.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kellymears