Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👍🏼 improve(minor): internals & tests #2373

Merged
merged 27 commits into from
Jul 17, 2023
Merged

👍🏼 improve(minor): internals & tests #2373

merged 27 commits into from
Jul 17, 2023

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented Jul 12, 2023 •
edited
Loading

  • Improve: passthrough command API. Removes a ton of duplicative code. Makes it easier for people to create their own.
  • Test: run integration tests as part of unit test suite (just without installation).
  • Test: improve coverage with module aliases
  • Internal: most of bud.api brought into bud directly. bud.promised is an array of promises. Queue be awaited with await bud.promise(). This replaces the equivalent (undocumented) functions in bud.api.
  • Internal: Run test specs through eslint/prettier

Type of change

PATCH: backwards compatible change

@github-actions github-actions bot added @roots/bud-build internal repository specific PR or issue labels Jul 14, 2023
@kellymears kellymears changed the title 👍🏼 improve: bud passthrough command api 👍🏼 improve: internals & tests Jul 17, 2023
@kellymears kellymears added the 🚀! automerge label Jul 17, 2023
@kodiakhq kodiakhq bot merged commit 70c4114 into main Jul 17, 2023
8 checks passed
@kodiakhq kodiakhq bot deleted the improve-passthrough-commands branch July 17, 2023 06:50
@kellymears kellymears changed the title 👍🏼 improve: internals & tests 👍🏼 improve(minor): internals & tests Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
config dependencies Pull requests that update a dependency file examples internal repository specific PR or issue @roots/bud @roots/bud-api @roots/bud-build @roots/bud-compiler @roots/bud-compress @roots/bud-dashboard @roots/bud-eslint @roots/bud-extensions @roots/bud-framework @roots/bud-hooks @roots/bud-imagemin @roots/bud-minify @roots/bud-prettier @roots/bud-purgecss @roots/bud-server @roots/bud-stylelint @roots/bud-tailwindcss @roots/bud-typescript @roots/container @roots/critical-css-webpack-plugin @roots/entrypoints-webpack-plugin test yarn 🚀! automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kellymears