Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃憤馃徏 improve(patch): prevent duplicate dashboard renders #2422

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented Aug 23, 2023

This actually sidesteps up an upstream issue with ink by rendering each compilation using the Static component.

Better ensures only one render per compilation in multi-compiler builds where the total rows rendered exceeds stdout rows.

Simplifies some of the unit tests using matchInlineSnapshot

Type of change

PATCH: backwards compatible change

@github-actions github-actions bot added the test label Aug 24, 2023
@kellymears kellymears self-assigned this Aug 24, 2023
@kellymears kellymears added the 馃殌! automerge label Aug 24, 2023
@kodiakhq kodiakhq bot merged commit 189de01 into main Aug 24, 2023
8 checks passed
@kodiakhq kodiakhq bot deleted the dashboard-duplicate-renders branch August 24, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant