Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ improve(patch): add @roots/bud-support/jsx-runtime #2426

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Conversation

kellymears
Copy link
Member

If users are using a version of React from before React's work on react/jsx-runtime, then react/jsx-runtime will be undefined.

The bud CLI requires this runtime and so all commands will fail to execute in that situation (or other equivalent situations).

This change re-exports the react/jsx-runtime via @roots/bud-support/jsx-runtime and configures typescript to include our package in the built bud.js code, since it will always be defined regardless of the user's application concerns.

Type of change

PATCH: backwards compatible change

@github-actions github-actions bot added the test label Aug 29, 2023
@kellymears kellymears added the 🚀! automerge label Aug 30, 2023
@kodiakhq kodiakhq bot merged commit 5397e6d into main Aug 30, 2023
8 checks passed
@kodiakhq kodiakhq bot deleted the jsx-runtime branch August 30, 2023 05:24
kodiakhq bot pushed a commit that referenced this pull request Aug 30, 2023
Fixes problem with proxy url created in #2426 

## Type of change

**PATCH: backwards compatible change**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant