Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摃 docs(none): fix community extensions URL in README.md #2447

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

talss89
Copy link
Sponsor Contributor

@talss89 talss89 commented Sep 12, 2023

URL was relative to roots/bud repo, now absolute.

Not sure how the docs are compiled from the templates in the repo, so have marked this PR as draft.

Thanks a lot for the link back to the extension! 馃憤

Type of change

NONE: internal change

URL was relative to roots/bud repo, now absolute
@github-actions github-actions bot added the internal repository specific PR or issue label Sep 12, 2023
@kellymears
Copy link
Member

TYVM. This seems good. I want to have an extensions directory on the bud.js.org site at some point but no time to do it right now.

If you want to compile the README just run yarn @bud docs from the repo root.

@talss89 talss89 marked this pull request as ready for review September 19, 2023 17:58
@talss89
Copy link
Sponsor Contributor Author

talss89 commented Sep 19, 2023

Thanks for compiling! Did a yarn and sucked up the last 20GiB of disk space - hadn't had chance to look into further. Extensions repo sounds like a good idea. Let me know if you'd like any help.

Probably should clear out my machine 馃

@kellymears
Copy link
Member

That's cray! The bud.js repo should "only" take up ~2.4G once fully built out. But yeah, I get not wanting to run repo commands with a full drive.

Thanks again for this fix and for your extension. I have some Pro Micro clones in my electronics bin.. maybe I'll make something daft like a clock or something so I can give your extension a proper go.

@kellymears kellymears added the 馃殌! automerge label Sep 19, 2023
@kodiakhq kodiakhq bot merged commit ff3c673 into roots:main Sep 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal repository specific PR or issue 馃殌! automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants