Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: --target becomes --filter #2460

Merged
merged 2 commits into from Sep 25, 2023
Merged

docs: --target becomes --filter #2460

merged 2 commits into from Sep 25, 2023

Conversation

talss89
Copy link
Sponsor Contributor

@talss89 talss89 commented Sep 24, 2023

@mikespainhower on Discord pointed out that --target seems to have been removed.

It looks like to me that the same functionality is now provided by --filter. Have tested --filter on a multi-instance setup and it targets the instance with the matching bud.context.label.

This PR is a search-replace on the docs page, --target becomes --filter.

Still haven't got a working Bud-dev setup running, so these will need compiling too (sorry).

Type of change

NONE: internal change

@github-actions github-actions bot added docs internal repository specific PR or issue labels Sep 24, 2023
@kellymears
Copy link
Member

kellymears commented Sep 25, 2023

Thank you!

In this case there was no need to run yarn @bud docs since the generated README.md contents didn't change.

Despite that, the root README.md had (unrelated) fixes waiting to be applied (whoops), so I ran the command anyway.

I also manually deployed this change (yarn @bud netlify deploy, but I'm the only one with credentials for deploying the docs because netlify is priced per seat and actually kinda expensive..)

The test failure was random -- sometimes e2e can be a bit flaky.

@kellymears kellymears added the 🚀! automerge label Sep 25, 2023
@kodiakhq kodiakhq bot merged commit b533ad0 into roots:main Sep 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs internal repository specific PR or issue 🚀! automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants