Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 fix(patch): bud.after sync callback error #2601

Merged
merged 2 commits into from
Jun 17, 2024
Merged

🩹 fix(patch): bud.after sync callback error #2601

merged 2 commits into from
Jun 17, 2024

Conversation

kellymears
Copy link
Member

Fixes error when bud.after is provided a synchronous callback function.

bud.after(bud => {
  console.log(`this should work`)
  console.error(`but doesn't`)
}

Type of change

PATCH: backwards compatible change

@kellymears kellymears self-assigned this Jun 17, 2024
@github-actions github-actions bot added the test label Jun 17, 2024
@kellymears kellymears added the 🚀! automerge label Jun 17, 2024
@kodiakhq kodiakhq bot merged commit e22ef17 into main Jun 17, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the fix-hooks-error branch June 17, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kellymears kellymears

Labels
examples @roots/bud-framework @roots/bud-hooks test 🚀! automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kellymears