Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grunt-notify to watch tasks #1172

Closed
wants to merge 1 commit into from
Closed

Conversation

maff
Copy link
Contributor

@maff maff commented Oct 17, 2014

Adds a system notification via grunt-notify when starting/completing LESS or JS building.

@QWp6t
Copy link
Sponsor Member

QWp6t commented Oct 18, 2014

This could probably be refactored. I'm wondering if we could create a rootsTasks(...) function that will dynamically compile that notify object (to something like rootsNotifications = {}) based on parameters passed to it, and then return the same array it was sent..

Then each watch task would be something like

tasks: rootsTasks(['less:dev', 'autoprefixer:dev'])

And notify could be something like

notify: rootsNotifications

Seems like that would be good for staying DRY. On the other hand, I have no idea how well this notify thing works or if we really even need it. That's not to mention that we're moving away from Grunt, so perhaps this should be revisited once we make the switch over to Gulp.

@retlehs
Copy link
Sponsor Member

retlehs commented Oct 19, 2014

we're moving away from Grunt, so perhaps this should be revisited once we make the switch over to Gulp.

^^

@retlehs
Copy link
Sponsor Member

retlehs commented Oct 19, 2014

ref #1138

@retlehs retlehs closed this Oct 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants