Sage 9 - fix bootstrap4 styles #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting errors in the build styles of Bootstrap 4 http://v4-alpha.getbootstrap.com/content/figures/
fix bootstrap4 styles
|
what is this fixing? |
|
Class changes in the v4 alpha which break
|
|
@aaemnnosttv Yes exactly. I just class .thumbnail replacing figures + alternatives .img-thumbnail In the current version of sage 9 can not perform "run NPM build" with error @extend ... |
| @extend .img-fluid; | ||
|
|
||
| // alternative styles | ||
| // @extend .img-thumbnail; |
There was a problem hiding this comment.
can you remove these two comments?
|
gotcha, thanks. remove those commented out lines and then this is good to merge |
remove comments
|
removed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.