Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set devUrl from Bedrock's .env (if it exists) #1683

Closed
wants to merge 1 commit into from

Conversation

leek
Copy link

@leek leek commented Jul 22, 2016

If Bedrock's .env file exists, we read it and set config.devUrl to the WP_HOME value from it. Otherwise, we continue as normal (using the value from manifest.json).

This will allow a seamless integration of Bedrock and Sage without compromising the flexibility of using Sage without Bedrock.

This is similar to #1640 but much simpler and is focused solely on using Sage with Bedrock (a common scenario, I assume).

@QWp6t
Copy link
Sponsor Member

QWp6t commented Jul 22, 2016

We appreciate that you took the time to submit a PR, but unfortunately we can't accept this one.

  1. We're not adding new features to Sage 8. Our focus is on Sage 9 at the moment.
  2. Bedrock is switching over to INI. Switch from Dotenv/env file to an INI file bedrock#240

You can try resubmitting your PR to target Sage 9 if you'd like (along with a plan to migrate to INI parsing), where it can be discussed whether to add this feature. For the record, I'm personally against this. I don't think we should be sniffing around the file system anywhere outside of the sage directory.

@QWp6t QWp6t closed this Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants