Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gulp error handling (Sage 8) #1832

Merged
merged 2 commits into from
Feb 7, 2017
Merged

Fix gulp error handling (Sage 8) #1832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bec9e9c
Update Bootstrap dependency to version 4.0.0-alpha.6
MWDelaney Dec 23, 2016
d67b65d
Add error handling to "scripts" and "styles" gulp tasks
MWDelaney Dec 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion assets/styles/common/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Grid settings
$enable-flex: true;
$main-sm-columns: 12;
$sidebar-sm-columns: 4;

Expand Down
2 changes: 1 addition & 1 deletion bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"license": "MIT",
"private": true,
"dependencies": {
"bootstrap": "git://github.com/twbs/bootstrap.git#v4.0.0-alpha.4"
"bootstrap": "git://github.com/twbs/bootstrap.git#v4.0.0-alpha.6"
}
}
8 changes: 8 additions & 0 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ var enabled = {
// Path to the compiled assets manifest in the dist directory
var revManifest = path.dist + 'assets.json';

// Error checking; produce an error rather than crashing.
var onError = function(err) {
console.log(err.toString());
this.emit('end');
};

// ## Reusable Pipelines
// See https://github.com/OverZealous/lazypipe

Expand Down Expand Up @@ -177,6 +183,7 @@ gulp.task('styles', ['wiredep'], function() {
});
}
merged.add(gulp.src(dep.globs, {base: 'styles'})
.pipe(plumber({errorHandler: onError}))
.pipe(cssTasksInstance));
});
return merged
Expand All @@ -191,6 +198,7 @@ gulp.task('scripts', ['jshint'], function() {
manifest.forEachDependency('js', function(dep) {
merged.add(
gulp.src(dep.globs, {base: 'scripts'})
.pipe(plumber({errorHandler: onError}))
.pipe(jsTasks(dep.name))
);
});
Expand Down