Add Tachyons as a CSS framework option #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sage works better without assuming PostCSS is part of the build process. Previously included version implements PostCSS. See: github.com/tachyons-css/tachyons-sass
|
I'd like to put my vote in to approve this one. Love Tachyons. |
|
+1 for Bulma support |
|
Every single front-end framework/library we add to the Sage repo we need to support minimally. My only issue is when I see Bluma (just as an example) added or requested, it might get to be a bit much. I like Tachyons, but at the same time if everyone wants this that and the other I don't think any of us are seeing the Sage repo be cluttered up. Thoughts? |
|
shit @davekiss sorry for letting this sit for so long. can you please fix the merge conflicts? then we'll get this in 👍 |
|
@retlehs I believe that should do it, but a quick review would be 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This framework has been picking up some traction, so thought I'd submit a PR to get it implemented in the Sage 9 generator.
http://tachyons.io/