Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding filter to define which conditions to enable primary sidebar on. #1883

Closed
wants to merge 1 commit into from

Conversation

pixleight
Copy link

function display_sidebar() in app/helpers.php referred to a filter that did not exist.

@QWp6t
Copy link
Sponsor Member

QWp6t commented Apr 20, 2017

Thanks for taking the time to submit a PR, but this was deliberately removed.

#1760

@QWp6t QWp6t closed this Apr 20, 2017
@pixleight
Copy link
Author

@QWp6t was an equivalent replacement added that I've overlooked?

@QWp6t
Copy link
Sponsor Member

QWp6t commented Apr 20, 2017

Nah. We just make the filter available for developers to do with as they please.

@rutger1140
Copy link

The code sample did help me out. I had to scroll back in the repo history to see how to use the filter. Maybe it's useful to include/document it somewhere?

@QWp6t
Copy link
Sponsor Member

QWp6t commented Apr 20, 2017

@rutger1140
Copy link

👌 thanks!

@mikedoubintchik
Copy link

What if I want to show the sidebar on all pages using the default page template, but hide it on a custom page template? @QWp6t

@retlehs
Copy link
Sponsor Member

retlehs commented Jun 21, 2017

@allurewebsolutions you use use the filter — you can do whatever you want with it. please don't use github for personal support requests 👉 https://discourse.roots.io/

@roots roots locked and limited conversation to collaborators Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants