New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullwidth page fix and theme options update. #197
Conversation
I accidentally included a deactivation hook in roots-options.php which I had intended to remove. It wouldn't really hurt anything and may even alleviate a few headaches for some but it could just be superfluous. Let me know and I'll fix and re-pull if needed. |
Could you remove the deactivation hook? We should consider it separately if it has some benefits. Don't want that change to get lost in this one. Otherwise, pull request looks like a needed solution. |
I removed the deactivation hook. It's really only useful to make sure options are rebuilt when a change is made during development. Cheers. |
thanks @johnnypeck - i would have pulled this in already but now i'm rethinking including the full width template. do you think it's worth it to keep it? |
@retlehs I think it makes sense to have the full width. It's a very common use case and if anything shows an example full width layout to start with for a child theme to implement. |
one last thing: in the options the label is called '#fullwidth CSS Classes' it's just a class on the #main ID so a better label might be something like 'Full Width CSS Classes' once that's updated i'll pull this in, thx @johnnypeck |
@retlehs No worries. Good call on the option naming. Have a good one. |
I went ahead and tried to implement this code and noticed this with 960.gs: When I created a new page with the Full Width Template in 960.gs, I successfully saw the However, when I made it the static "Front Page" in the WordPress "Reading" settings, the sidebar div reappeared. I figured it was a If I figure something out I'll add a pull request. Thanks a lot @johnnypeck and @retlehs! |
@aboutaaron WordPress automatically uses front-page.php if it is present in a theme when you select a static home page. If it was not present in roots then you could use any template you like. |
@retlehs Any word on getting this pull merged? |
full width template, thx @johnnypeck!
done with 9da422e, thx @johnnypeck |
Bump WordPress to 4.3
Fix the full page width issue, adds a theme option for the class and sets some sensible defaults for the various frameworks on that option.