Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uglifyjs plugin #2070

Merged
merged 4 commits into from Jun 16, 2018
Merged

Add uglifyjs plugin #2070

merged 4 commits into from Jun 16, 2018

Conversation

jasonbaciulis
Copy link
Contributor

Simply use UglifyJs plugin instead of Webpack built-in version which allows us to configure it. I'm including one useful feature to drop console.log statements to avoid eslint errors on build:production

Related to discourse discussion: https://discourse.roots.io/t/uglifyjs-error-on-production-build/12419/4?u=jasonbaciulis

@QWp6t QWp6t merged commit fd2a94f into roots:master Jun 16, 2018
@QWp6t
Copy link
Sponsor Member

QWp6t commented Jun 16, 2018

Thanks!

oxyc added a commit to generoi/sage that referenced this pull request Jun 27, 2018
* roots/master: (41 commits)
  Add uglifyjs plugin (roots#2070)
  Add missing trailing commas in 2f51b51
  Run autoprefixer before minification
  Enable source comments in Sass
  Fix travis CI build error (missing trailing comma)
  Tweaked SVGO settings
  Make template() compatible with wp admin
  9.0.1
  Update to Bootstrap 4.1.1
  Remove useless whitespace
  Auto-detect  scheme
  Close roots#2028 - Increase priority on comments_template filter
  Remove Font Awesome reference [ci skip]
  Bump sage-lib
  Close roots#1962 - Bump to Laravel 5.6
  Remove php blade shorthand
  Stable vs dev install messaging, ref roots/docs#140 [ci skip]
  Update some dependencies
  Update CHANGELOG [ci skip]
  Bootstrap 4.1.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants