This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Fix js error, caused by replace single quotes #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, script tags might contain js code document.write() with single quotes - like [wp_get_script_polyfill](https://developer.wordpress.org/reference/functions/wp_get_script_polyfill/). Replacing all single quotes lead to an SyntaxError. So add slashes in document.write arguments fixes this.
|
thank you for this contribution! my apologies for the extremely long delay in getting this landed |
|
Hi, When you reckon this fix will land in the WP plugin release? |
|
Hi,
I'm not sure what you mean? The fix has been already released in version 3.9.0. |
|
My bad. |
|
AFAIK the plugin has never been released in WordPress Plugins Directory. You can use Composer or GitHub Updater plugin to get the updates automatically. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, script tags might contain js code document.write() with single quotes - like wp_get_script_polyfill. Replacing all single quotes lead to an SyntaxError. So add slashes in document.write arguments fixes this.