Ansible 2.8 support #1103
Merged
Ansible 2.8 support #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
force-pushed
the
ansible-2.8
branch
3 times, most recently
from
ae7de04
to
e48996e
Compare
swalkinshaw
force-pushed
the
ansible-2.8
branch
from
e48996e
to
623d163
Compare
CLI options changed a lot in 2.8. This updates our callback plugin to support both 2.7 and 2.8 by normalizing each case into a dict. Ref: ansible/ansible#50069
swalkinshaw
force-pushed
the
ansible-2.8
branch
from
48a910d
to
d4922a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1085
From my initial testing this was the main thing preventing Trellis from supporting Ansible 2.8. The callback plugin has been updated to support both 2.7 and 2.8 so we won't force 2.8 yet.
2.8 does introduce a couple of new warnings/deprecations but we some are in Galaxy packages that we can't fix yet anyway.
It should be noted that 2.8 does not require Python 3 either.