Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
X-Cache-Enabled
HTTP header tonginx
responses. It will not be added when upstream cache status isBYPASS
as then no caching is used for the request.WordPress Site Health Page Caching uses specific HTTP header values in the loopback HTTP response in order to detect that page caching is indeed enabled.
The related
Fastcgi-Cache
HTTP header is added by Trellis, but not used by the WordPress site health check.Adding this to Trellis by default appears to be a good idea (no obvious side-effects, improving compatibility with WordPress core (site health check)).
See roots discussion: https://discourse.roots.io/t/site-health-check-page-cache-not-detected/25640/2
Note: Should this
X-Cache-Enabled
HTTP header only be added to loopback requests? On the other hand, theFastcgi-Cache
HTTP header is also already added to all requests.Possible alternative: A Bedrock MU plugin that uses the
Fastcgi-Cache
HTTP header to setX-Cache-Enabled
in PHP code.