Composer config github-oauth #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| - name: Composer config github-oauth | ||
| command: composer config -g github-oauth.github.com {{ composer_githuboauth }} | ||
| when: composer_githuboauth is defined |
There was a problem hiding this comment.
@thiagotalma little nitpick, but could the variable be called composer_github_oauth_token?
|
some details on what this is for would be helpful for people coming to look at this pull request |
|
@swalkinshaw done! @retlehs I'm sorry I have not done before. |
|
@thiagotalma would you be able to squash these two commits into 1? Guide if you need it: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit |
|
Landed in 625ca3f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility of including the token used on Github.
According to the instructions here: https://getcomposer.org/doc/articles/troubleshooting.md#api-rate-limit-and-oauth-tokens