Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update galaxy roles for Ansible 2.2 compatibility #681

Merged
merged 3 commits into from Nov 5, 2016

Conversation

fullyint
Copy link
Contributor

@fullyint fullyint commented Nov 5, 2016

MailHog. This PR fixes #679, a conflict between an out-of-date MailHog galaxy role and Ansible 2.2 (also noted at discourse). Note that the latest MailHog role switches to using mhsendmail, "a sendmail replacement for MailHog," so dev.yml no longer needs the ssmtp role and group_vars/development/mail.yml no longer needs the ssmtp variables. We could potentially move the one remaining variable to group_vars/development/main.yml and remove the mail.yml file.

Logrotate. This PR also fixes a conflict between the logrotate galaxy role and Ansible 2.2. The out-of-date logrotate role included a "bare" variable which now fails in Ansible 2.2. This PR updates to latest logrotate role version that has this update:

- with_items: logrotate_scripts
+ with_items: "{{ logrotate_scripts }}"

NTP. This PR replaces the resmo.ntp galaxy role with the geerlingguy.ntp role, which may have a little more activity. In this latter, the task "Set the correct timezone" replaces our common role's timedatectl set-timezone command. The two tasks do the same thing. The timedatectl manpage says the set-timezone command "will alter the /etc/localtime symlink," which is what the geerlingguy role does manually. Note: geerlingguy's role uses the variable ntp_timezone so I renamed the Trellis default_timezone variable to ntp_timezone.

Other roles. The PR also updates the geerlingguy.composer and geerlingguy.daemonize roles. These changes appear minor, not requiring discussion.

Tested on Ansible versions 2.0.2.0, 2.1.1.0, and 2.2.0.0

@swalkinshaw
Copy link
Member

Everything looks good 👍

@fullyint fullyint merged commit a212765 into master Nov 5, 2016
@fullyint fullyint deleted the galaxy-roles-update branch November 5, 2016 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vagrant Up fails under Ansible 2.2.0.0
2 participants