Redirect directly to https canonical domain #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://www.xyz.com -> http://xyz.com -> https://xyz.com becomes simply http://www.xyz.com -> https://xyz.com Also move return directive back into location block so that it will run only if acme challenge location is not matched. Otherwise Let's Encrypt validation in this server block would fail due to 301 redirect.
swalkinshaw
approved these changes
Sep 18, 2017
HowardMei
added a commit
to HowardMei/dotrellis
that referenced
this pull request
Oct 7, 2017
* 'master' of https://github.com/roots/trellis: (53 commits) Revert "Vagrant: Use DHCP by default" Vagrant: Use DHCP by default Extract package names from `apt` tasks into variables Remove `update_cache` parameter from `apt` tasks Normalize `apt` tasks and check package variables format Ansible 2.4 compatibility CHANGELOG updates Default h5bp expires and cache busting to false Remove WP transient _site_transient_theme_roots during deploys Deploys: Minimize delay in updating WP theme paths Fix multisite_subdomains Ruby compat Extract Trellis::Config (roots#890) Vagrant: Support DHCP Redirect directly to https canonical domain (roots#889) Ansible: Retry ssh connection one more time Re-enable IPv4 connections in Nginx no-default.conf (roots#885) Ensure updated H5BP nginx includes sync into place (roots#884) WordPress Setup: Add Nginx ssl_client_certificate (roots#869) Nginx: Include includes.d/http/*.conf Nginx: Add include.d files to redirect domains (roots#879) ...
primozcigler
added a commit
to primozcigler/trellis
that referenced
this pull request
Nov 2, 2017
* trellis/master: (52 commits) Dynamically increase ansible_group_priority for selected env (roots#909) Bump Ansible version_tested_max to 2.4.1.0 (roots#911) Clarify DB task name. Update wp-cli to 1.4.0. Update placeholder deploy_build_before hook example [ci skip] Revert "Vagrant: Use DHCP by default" Vagrant: Use DHCP by default Extract package names from `apt` tasks into variables Remove `update_cache` parameter from `apt` tasks Normalize `apt` tasks and check package variables format Ansible 2.4 compatibility CHANGELOG updates Default h5bp expires and cache busting to false Remove WP transient _site_transient_theme_roots during deploys Deploys: Minimize delay in updating WP theme paths Fix multisite_subdomains Ruby compat Extract Trellis::Config (roots#890) Vagrant: Support DHCP Redirect directly to https canonical domain (roots#889) Ansible: Retry ssh connection one more time ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://discourse.roots.io/t/secure-non-secure-www-non-www-redirects/10420/2
http://www.xyz.com -> http://xyz.com -> https://xyz.combecomes simply
http://www.xyz.com -> https://xyz.com.Also moves
return 301directive back intolocationblock so that it will run only if acme challengelocationis not matched. Otherwise Let's Encrypt validation in thisserverblock fails due to redirect.