Replace bare Dataloader() with pre-loaded play._loader #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The play._loader already exists. It is pre-loaded with play._loader._vault.secrets, play._loader.FILE_CACHE, etc. There's little point in creating a fresh Dataloader() and having to process or load it up.
swalkinshaw
approved these changes
Nov 12, 2017
primozcigler
added a commit
to primozcigler/trellis
that referenced
this pull request
Nov 19, 2017
* tag '1.0.0-rc.2': 1.0.0-rc.2 Update to WP-CLI 1.4.1. Disallow duplicate site keys within a host's wordpress_sites (roots#910) Replace bare Dataloader() with pre-loaded play._loader (roots#917) Remove outdated to_unicode import from plugin utils (roots#916) Fix raw_vars functionality for Ansible 2.4.1 (roots#915) Enable ioapic Update vagrant_box_version to current release
primozcigler
added a commit
to proteusthemes/pt-ops
that referenced
this pull request
Jan 5, 2018
* trellis/master: (292 commits) Bump Ansible version_tested_max to 2.4.2.0 (roots#932) Add MariaDB 10.2 PPA Remove cron_file if WP system cron disabled (roots#927) Add Code of Conduct [ci skip] Expose the deploy_helper keep_releases option (roots#922) Close roots#580 - Switch from .dev to .test Update acme-tiny commit hash Enable select deploy configs to optionally vary by site (roots#919) 1.0.0-rc.2 Update to WP-CLI 1.4.1. Disallow duplicate site keys within a host's wordpress_sites (roots#910) Replace bare Dataloader() with pre-loaded play._loader (roots#917) Remove outdated to_unicode import from plugin utils (roots#916) Fix raw_vars functionality for Ansible 2.4.1 (roots#915) Enable ioapic Update vagrant_box_version to current release Dynamically increase ansible_group_priority for selected env (roots#909) Bump Ansible version_tested_max to 2.4.1.0 (roots#911) Clarify DB task name. Update wp-cli to 1.4.0. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃Ч
The
play._loaderalready exists. It is pre-loaded withplay._loader._vault.secrets,play._loader.FILE_CACHE, etc. There's little point in creating a freshDataloader()and having to process or load it up.The life of a
loaderNo need to read this.
The
ansible-playbookcli commandPlaybookCLI()runs its base class's_play_prereqs()which initializes a newloaderand processes it, runningsetup_vault_secrets()etc.The
PlaybookCLIthen passes this pre-loadedloaderinstance to thePlaybookExecutorwhich forwards on theloaderviaPlaybook.load()which uses theloaderto initialize a newPlaybook().The
Playbook()uses theloaderto initialize our givenPlay(). Finally, Trellis can access theplay._loadervia thev2_playbook_on_play_startcallback method.This
loaderis all loaded up withvault_secretsand_FILE_CACHE, in contrast to a bare newDataloader()we've been using and would otherwise need to load up manually. The pre-loaded_loader._vault.secretsobviates procedures such as this.