Use Purl 0.0.8 #16
Closed
Use Purl 0.0.8 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed it would be nice to get rid of the Purl dependency if it's fairly trivial. Do you want to look into that a bit before this is merged? |
|
Closed. Went with #18 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to version 0.0.8, Purl uses
parse_strwithout a second parameter. In PHP 7.2+ this emits an E_DEPRECATED notice.Purl is currently at version 0.0.10, but that one requires PHP 7.1 instead of 5.3, so it's not an option for this plugin unless the version requirement is changed for it as well.
Perhaps using Purl is not even necessary for its use case. This is something that could be investigated in a separate PR.