Move gems to Gemfile and improve rubocop config #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwolman
force-pushed
the
move-gems-to-gemfile
branch
from
9e4707f
to
933d01d
Compare
mwolman
requested review from
guillermoap,
adlamas,
santiagodiaz and
JoDaBaRo
mwolman
force-pushed
the
move-gems-to-gemfile
branch
from
933d01d
to
f2d73e1
Compare
guillermoap
reviewed
Sep 27, 2023
| @@ -0,0 +1,269 @@ | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
shouldn't this change be a renaming git change? this way we are losing the history of the file. Try using git mv spec/lib/outboxable_spec.rb spec/lib/active_outbox/outboxable_spec.rb
There was a problem hiding this comment.
Tried what you mentioned, but it didn't work 😕 it has too many changes, so it recognizes it as a new file
mwolman
force-pushed
the
move-gems-to-gemfile
branch
2 times, most recently
from
f3d1a6f
to
d38609c
Compare
guillermoap
approved these changes
Oct 4, 2023
mwolman
force-pushed
the
move-gems-to-gemfile
branch
from
7cdc127
to
2281d23
Compare
mwolman
force-pushed
the
move-gems-to-gemfile
branch
from
dcc7ff5
to
b939e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm implementing the following improvements:
.rubocop.ymlfile and fix multiple issuesOutboxableclass and spec in order to fix some issuesgemspecto theGemfileto follow good practices: