Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec for outbox class not found error #8

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Spec for outbox class not found error #8

merged 1 commit into from
Oct 11, 2023

Conversation

santiagodiaz
Copy link
Contributor

This PR is to add a spec for raising ActiveOutbox::OutboxClassNotFoundError when the ActiveOutbox configuration is not set under config/initializers/active_outbox.rb with the default outbox class

@santiagodiaz santiagodiaz changed the base branch from main to move-gems-to-gemfile October 4, 2023 15:32
@santiagodiaz santiagodiaz force-pushed the spec-for-outbox-class-not-found branch from 857212d to 73bcabd Compare October 4, 2023 15:34
@santiagodiaz santiagodiaz changed the title [WIP] Spec for outbox class not found error Spec for outbox class not found error Oct 4, 2023
@santiagodiaz santiagodiaz marked this pull request as ready for review October 4, 2023 16:06
@mwolman mwolman force-pushed the move-gems-to-gemfile branch 2 times, most recently from dcc7ff5 to b939e55 Compare October 4, 2023 17:06
Base automatically changed from move-gems-to-gemfile to main October 4, 2023 17:37
@santiagodiaz santiagodiaz force-pushed the spec-for-outbox-class-not-found branch from 618d923 to 1d0b9f1 Compare October 4, 2023 21:38
guillermoap
guillermoap approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@guillermoap guillermoap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! only comment is we should fix the duplicated commits with a rebase

@santiagodiaz santiagodiaz force-pushed the spec-for-outbox-class-not-found branch from 1d0b9f1 to a800fa1 Compare October 5, 2023 15:11
@santiagodiaz santiagodiaz force-pushed the spec-for-outbox-class-not-found branch from a800fa1 to f6fa243 Compare October 5, 2023 16:03
@santiagodiaz santiagodiaz merged commit 1ca79ad into main Oct 11, 2023
4 of 5 checks passed
@santiagodiaz santiagodiaz deleted the spec-for-outbox-class-not-found branch October 11, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillermoap guillermoap guillermoap approved these changes

@mwolman mwolman mwolman approved these changes

@adlamas adlamas Awaiting requested review from adlamas

@JoDaBaRo JoDaBaRo Awaiting requested review from JoDaBaRo JoDaBaRo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@santiagodiaz @guillermoap @mwolman