Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change token configuration for devise token auth #43

Merged
merged 1 commit into from
May 8, 2017

Conversation

MaicolBen
Copy link
Contributor

@MaicolBen MaicolBen commented Mar 9, 2017

This PR includes:

  • Changed default token lifespan for a year, it should be changed for Web-apps as frontend
  • Disable change tokens due to random problems
  • Recommend in README to change the app timezone
  • Increase token batch window
  • Give info about how to remove facebook

@@ -2,4 +2,6 @@
config.default_confirm_success_url = '/'
config.default_password_reset_url = ENV['PASSWORD_RESET_URL']
config.enable_standard_devise_support = true
config.token_lifespan = 1.year
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaicolBen We should add a new entry in the templates for web projects to change this value, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@santiagovidal santiagovidal self-requested a review May 8, 2017 16:58
@santiagovidal santiagovidal merged commit 2eebd38 into master May 8, 2017
@santiagovidal santiagovidal deleted the feature/improve-config branch May 8, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants