Import devise token auth using https #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toptierlabs
changed the title
matiasmansilla1989
force-pushed
the
fix/import_devise_token_auth_using_https
branch
from
b88f3d4
to
5a20caa
Compare
| @@ -65,4 +65,4 @@ group :assets do | |||
| end | |||
|
|
|||
| # Windows does not include zoneinfo files, so bundle the tzinfo-data gem | |||
| gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw jruby] | |||
| gem 'tzinfo-data', platforms: %i(mingw mswin x64_mingw jruby) | |||
There was a problem hiding this comment.
Small fix to address rubocop's concern. Code climate uses a different version of Rubocop, even when we have a newer version, this problem is not detected.
matiasmansilla1989
requested review from
diebarral,
santiagovidal and
MaicolBen
MaicolBen
reviewed
Sep 21, 2017
Gemfile
Outdated
| @@ -9,7 +9,7 @@ gem 'carrierwave', '~> 0.11.2' | |||
| gem 'carrierwave-base64', '~> 2.3.4' | |||
| gem 'delayed_job_active_record', '~> 4.1.2' | |||
| gem 'devise', '~> 4.3.0' | |||
| gem 'devise_token_auth', github: 'rootstrap/devise_token_auth' | |||
| gem 'devise_token_auth', git: 'https://github.com/rootstrap/devise_token_auth', branch: :master | |||
There was a problem hiding this comment.
master is the default one, I think you can remove this
matiasmansilla1989
force-pushed
the
fix/import_devise_token_auth_using_https
branch
from
5a20caa
to
f80101f
Compare
diebarral
approved these changes
Sep 21, 2017
matiasmansilla1989
force-pushed
the
fix/import_devise_token_auth_using_https
branch
from
f80101f
to
b9b752e
Compare
santiagovidal
approved these changes
Sep 21, 2017
MaicolBen
approved these changes
Sep 21, 2017
MaicolBen
pushed a commit
that referenced
this pull request
Sep 22, 2017
…ing_https Import devise token auth using https
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
codeclimate.ymlfile. An issue Add/Define a new code_climate.yml file. #91 is opened to discuss and create a newcodeclimate.ymlfile with the proper configuration.