Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Commit

Permalink
Merge branch 'devel'
Browse files Browse the repository at this point in the history
  • Loading branch information
adamhsparks committed Nov 17, 2020
2 parents 52271a4 + ab5c6e2 commit 6980fa7
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 35 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
@@ -1,7 +1,7 @@
Package: bomrang
Type: Package
Title: Australian Government Bureau of Meteorology ('BOM') Data Client
Version: 0.7.1.9000
Version: 0.7.2
Authors@R:
c(person(given = "Adam H.",
family = "Sparks",
Expand Down
4 changes: 3 additions & 1 deletion NEWS.md
@@ -1,4 +1,6 @@
# bomrang (development version)
# bomrang 0.7.2

* Fixes an example that wrote to R userspace, when it should not in `get_radar_imagery()`

# bomrang 0.7.1

Expand Down
2 changes: 2 additions & 0 deletions R/get_radar_imagery.R
Expand Up @@ -111,6 +111,8 @@ get_available_radar <- function(radar_id = "all") {
#' imagery <- get_radar_imagery(product_id = "IDR032")
#' plot(imagery)
#'
#' # Save imagery to a local path
#' imagery <- get_radar_imagery(product_id = "IDR032", path = "image.gif")
#' }
#'
#' @author Dean Marchiori, \email{deanmarchiori@@gmail.com}
Expand Down
11 changes: 3 additions & 8 deletions codemeta.json
Expand Up @@ -10,13 +10,13 @@
"codeRepository": "https://github.com/ropensci/bomrang",
"issueTracker": "https://github.com/ropensci/bomrang/issues",
"license": "https://spdx.org/licenses/MIT",
"version": "0.7.1",
"version": "0.7.2",
"programmingLanguage": {
"@type": "ComputerLanguage",
"name": "R",
"url": "https://r-project.org"
},
"runtimePlatform": "R version 4.0.2 (2020-06-22)",
"runtimePlatform": "R version 4.0.3 (2020-10-10)",
"provider": {
"@id": "https://cran.r-project.org",
"@type": "Organization",
Expand Down Expand Up @@ -582,13 +582,8 @@
"https://CRAN.R-project.org/package=bomrang",
"https://docs.ropensci.org/bomrang/"
],
"review": {
"@type": "Review",
"url": "https://github.com/ropensci/software-review/issues/121",
"provider": "https://ropensci.org"
},
"developmentStatus": "https://www.repostatus.org/#active",
"copyrightHolder": {},
"funder": {},
"fileSize": "657668.552KB"
"fileSize": "1360.913KB"
}
31 changes: 6 additions & 25 deletions cran-comments.md
@@ -1,41 +1,22 @@
## bomrang version 0.7.2

## Test environments

- local macOS install R version 4.0.2 (2020-06-22)
- local macOS install R version 4.0.3 (2020-10-10)

- win-builder R Under development (unstable) (2020-09-17 r79226)
- win-builder R Under development (unstable) (2020-11-14 r79432)

- win-builder R version 4.0.2 (2020-06-22)
- win-builder R version 4.0.3 (2020-10-10)

## R CMD check results

0 errors | 0 warnings | 1 note

This is a resubmission that removes functionality due to a broken CRAN package so that all examples in this package pass checks

## Removal of functionality

* `get_subdaily_weather()` has been removed due to CRAN policy for failing examples so that I can get the bug fixes in this package submitted to deal with errors that do originate in this package as the failing example is a direct result of the _stationAry_ package which is already on CRAN, not _bomrang_.
This is a new patch release that fixes a bug in the documentation

## Bug fixes

* For a time BOM was not listing historical rainfall records.
A message is emitted now if records are missing or unavailable rather than `get_historical_weather()` failing.
Thanks to James Goldie, [@rensa](https://github.com/rensa) for this fix.

* Cross-links in the function documentation have been fixed.

## Standardised function naming

* `get_historical()` is now an alias for `get_historical_weather()` to bring this function into line with the other function names.
Neither name is preferred and both will be provided going forward.
This is simply to provide a standard nomenclature across the package for function names.

## Internal changes

* Update internal databases of station and forecast locations.

* Reorganise functions and files to be more consistent within the package.
* Fixes an example that wrote to R userspace, when it should not in `get_radar_imagery()`

## Reverse dependencies

Expand Down
2 changes: 2 additions & 0 deletions man/get_radar_imagery.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6980fa7

Please sign in to comment.