-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition from crayon to cli #167
Conversation
…n favour of `cli::cat_rule()` Also get rid of crayon ansi markup condition (cli takes care of that)
…to .Rbuildignore.
…ng dir + removing line and column numbers if they are NAs.
Thanks @olivroy for this excellent improvement. Could you please remove |
@mpadge Can't request review via gh (not a member), but I addressed your comments and fixed merge conflicts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @olivroy
Glad to see the package under rOpensci! |
Before :
![image](https://private-user-images.githubusercontent.com/52606734/336611792-a239198d-06f7-4651-a99f-377aba150662.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3NTg1MzIsIm5iZiI6MTcyMDc1ODIzMiwicGF0aCI6Ii81MjYwNjczNC8zMzY2MTE3OTItYTIzOTE5OGQtMDZmNy00NjUxLWE5OWYtMzc3YWJhMTUwNjYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEyVDA0MjM1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRjZDJlOGU0YTkxZDAyMmFlZTQxNmY0Zjk1Mzg2NWU2M2E3MGM5ZWEyMDYyODM1NmU1NDU2NjUyYmFiNWJkNmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.LI9KzGnZrs98IczJQMn_YM0lKKQ5OekZDH88dGQTGTc)
This PR:
Summary
Gets rid of crayon and clisymbols, both superseded by cli
cli::cat_rule()
is quite handy (you can pass many parameters to...
incat_rule()
https://cli.r-lib.org/reference/rule.html.Create clickable links to path in console (had to strip NA to make sure paths were correct. i.e.
{.path path/to/file.R:NA}
doesn't work. Makes output cleaner, see snapshotsUse more cli messaging for announcing which steps are taking place. e.g.
![image](https://private-user-images.githubusercontent.com/52606734/336612164-1e0e0c37-f773-44e2-a3a9-cafb9dba018e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3NTg1MzIsIm5iZiI6MTcyMDc1ODIzMiwicGF0aCI6Ii81MjYwNjczNC8zMzY2MTIxNjQtMWUwZTBjMzctZjc3My00NGUyLWEzYTktY2FmYjlkYmEwMThlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEyVDA0MjM1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM3NzgyMDk3Njk4ZWNmYTQ0MGY1YjMxNTA3NGQyYTE4MzMwMjlkZDQyNTQ4OWVlZTM0NWExYzY4MTkxMDE5OGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.SC-2uXSD5bF3F8Sm1padcfvOmUM8Sq3es5fbAkpxzck)
The change of character in snapshot only occurs because in non-interactive sessions, cli uses unicode(?) symbols only, but no change in interactive session.
Removed
x
argument fromgp_footer()
as it is unusedHappy to answer questions