Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from crayon to cli #167

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Jun 4, 2024

Before :
image

This PR:

image

Summary

  • Gets rid of crayon and clisymbols, both superseded by cli

  • Create clickable links to path in console (had to strip NA to make sure paths were correct. i.e. {.path path/to/file.R:NA} doesn't work. Makes output cleaner, see snapshots

  • Use more cli messaging for announcing which steps are taking place. e.g.
    image

  • The change of character in snapshot only occurs because in non-interactive sessions, cli uses unicode(?) symbols only, but no change in interactive session.

  • Removed x argument from gp_footer() as it is unused

Happy to answer questions

@mpadge
Copy link
Member

mpadge commented Jun 5, 2024

Thanks @olivroy for this excellent improvement. Could you please remove codemeta.json from the PR? (Details there are system dependent, and will create a lot of merge conflicts.) Please also merge the latest NEWS.md, which has just been updated. I'm pretty sure once that's done, we should be good to merge. Please request a review from me when you're ready. Thanks!

@olivroy
Copy link
Contributor Author

olivroy commented Jun 5, 2024

@mpadge Can't request review via gh (not a member), but I addressed your comments and fixed merge conflicts!

Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @olivroy

@mpadge mpadge merged commit b215780 into ropensci-review-tools:main Jun 5, 2024
6 checks passed
@olivroy
Copy link
Contributor Author

olivroy commented Jun 5, 2024

Glad to see the package under rOpensci!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants