Cache calls to units::valid_udunits_prefixes() #333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a performance issue with the entire shiny_attributes app reported in #332.
Before this change, when launching the Shiny app and when editing attributes, a somewhat slow call from the
units
package, units::valid_udunits_prefixes() would get called. This meant slow startup time for the Shiny app and also clunky editing.My solution was to cache the slow call on its first call and re-use the cached value. This was implemented with an Environment.