Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring bulk import #27

Merged
merged 7 commits into from Jun 18, 2019
Merged

refactoring bulk import #27

merged 7 commits into from Jun 18, 2019

Commits on Jun 17, 2019

  1. Configuration menu
    Copy the full SHA
    9a35b10 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. update tests

    cboettig committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    183fbb6 View commit details
    Browse the repository at this point in the history
  2. slightly more robust bulk import

    Ultimately this probably needs to be more configurable, in particular, in supporting colClasses specification (or at least a default) and in specifying quote char.  This should be captured from the `...` argument to `unark` and past to bulk.
    
    for example, readr default tsv still uses quotes as escape. (e.g. all taxadb data-raw call write_tsv without specifying `quote=""` as in the tsv standard...).
    cboettig committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    1ad8c9e View commit details
    Browse the repository at this point in the history
  3. use ... for unnamed args

    cboettig committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    9133ae9 View commit details
    Browse the repository at this point in the history
  4. Need more robust handling before we can pass ...

    For now, omit ... from monet.read.csv call.  `...` may contain arguments to readr::read_tsv that will not be recognized by `read.table`  and thus may cause errors
    cboettig committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    d8c9829 View commit details
    Browse the repository at this point in the history
  5. include timings

    cboettig committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    5ae5ea6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    71012e8 View commit details
    Browse the repository at this point in the history