Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No interaction between MRCA prior and clock models #43

Closed
richelbilderbeek opened this issue Jul 21, 2018 · 1 comment
Closed

No interaction between MRCA prior and clock models #43

richelbilderbeek opened this issue Jul 21, 2018 · 1 comment
Projects
Process rOpenSci feedback

Comments

@richelbilderbeek
Copy link
Member

Feedback bjoelle:

the relaxed clock model doesn't work with MRCA priors that have a time calibration distribution: the state, operators, distribution and tracelog sections are all missing elements compared to an XML produced with BEAUti. This issue appears to be linked to clock_models_to_xml_state l24-25: the comment is unclear as to whether it is supposed to be checking for any or no MRCA priors, and no check is performed here for either.
@richelbilderbeek richelbilderbeek mentioned this issue Jul 21, 2018
Closed
@richelbilderbeek richelbilderbeek added this to To do in Process rOpenSci feedback via automation Jul 21, 2018
richelbilderbeek pushed a commit that referenced this issue Oct 26, 2018
Add MRCA tests, fix #43
05c3f5e
@richelbilderbeek
Copy link
Member Author

Agreed! I've added a test to verify this. And indeed, bjoelle was right. Fixed it!

Process rOpenSci feedback automation moved this from To do to Done Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Process rOpenSci feedback
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richelbilderbeek