Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_site_model_n_params and get_site_model_n_distrs assume gamma rate categories #50

Closed
richelbilderbeek opened this issue Jul 21, 2018 · 1 comment
Closed

get_site_model_n_params and get_site_model_n_distrs assume gamma rate categories #50

richelbilderbeek opened this issue Jul 21, 2018 · 1 comment
Projects
Process rOpenSci feedback

Comments

@richelbilderbeek
Copy link
Member

Feedback bjoelle:

get_site_model_n_params and get_site_model_n_distrs do not check if the site model has gamma rate categories, they just assume it does
@richelbilderbeek richelbilderbeek mentioned this issue Jul 21, 2018
Closed
@richelbilderbeek richelbilderbeek added this to To do in Process rOpenSci feedback via automation Jul 21, 2018
@richelbilderbeek richelbilderbeek moved this from To do to In progress in Process rOpenSci feedback Sep 22, 2018
richelbilderbeek pushed a commit that referenced this issue Oct 25, 2018
Add 'get_gamma_site_model_n_distrs', progress #50
89aa46a
@richelbilderbeek
Copy link
Member Author

richelbilderbeek commented Oct 25, 2018 •
edited
Loading

bjoelle spotted that well: for a gamma cat count below 2, there is no distribution.

n_distrs

richelbilderbeek pushed a commit that referenced this issue Oct 25, 2018
Site model has the correct number of distributions depending on the g…
2221ff4 
…amma site model, progress #50
@richelbilderbeek richelbilderbeek moved this from In progress to To be checked by Travis CI in Process rOpenSci feedback Oct 25, 2018
Process rOpenSci feedback automation moved this from To be checked by Travis CI to Done Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Process rOpenSci feedback
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richelbilderbeek