Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#32 #34

Merged
merged 4 commits into from
Aug 15, 2019
Merged

Issue#32 #34

merged 4 commits into from
Aug 15, 2019

Conversation

benjaminschwetz
Copy link

What I actually meant to do... replace the regex for the categories to handle lack of spaces.

@ottlngr
Copy link
Contributor

ottlngr commented Aug 7, 2019

Hi, thanks for the issue and the pull request. Are you familiar with testthat? If so, I would appreciate you to add a test case that covers reading .bib files of the kind you had trouble with.

@benjaminschwetz
Copy link
Author

sure. will do

@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #34 into master will decrease coverage by 0.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   66.82%   66.45%   -0.37%     
==========================================
  Files           6        6              
  Lines         205      161      -44     
==========================================
- Hits          137      107      -30     
+ Misses         68       54      -14
Impacted Files Coverage Δ
R/bib2df_gather.R 94.36% <100%> (-1.68%) ⬇️
R/df2bib.R 9.52% <0%> (+2.11%) ⬆️
R/bib2df.R 69.23% <0%> (+9.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f9486...491f0ec. Read the comment docs.

@ottlngr ottlngr changed the base branch from master to v1.1.2 August 15, 2019 18:04
@ottlngr ottlngr merged commit 0acaf61 into ropensci:v1.1.2 Aug 15, 2019
@ottlngr
Copy link
Contributor

ottlngr commented Aug 15, 2019

Thanks for your contribution. I merged your changes into the v1.1.2 branch. I'm planning to fix some other issues in this branch and will merge back into master soon.

@ottlngr
Copy link
Contributor

ottlngr commented Jul 2, 2020

Hi @benjaminschwetz ,

sorry for the delay. Yesterday I merged your changes into master. The test cases you added run successfully, so I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants