Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in getSummaryFile due to bug in readr #2

Closed
alartin opened this issue Jan 14, 2017 · 2 comments
Closed

Bug in getSummaryFile due to bug in readr #2

alartin opened this issue Jan 14, 2017 · 2 comments

Comments

@alartin
Copy link

alartin commented Jan 14, 2017

Hi,
There is a bug in readr read_tsv and it only parses partial bacteria assembly_summary file. For example, there is over 80,000 rows and only 40,000 + rows loaded due to the quote. But read_tsv lacks of qoute option and it can be fixed by read_delim which you can set quote option.

@HajkD
Copy link
Member

HajkD commented Jan 17, 2017

Hi Xin,

thank you so much for pointing this out to me!
I wasn't aware of this readr package bug.

I will replace read_tsv by read_delim today and come back to you.

Many thanks!

HajkD added a commit that referenced this issue Jan 17, 2017
HajkD added a commit that referenced this issue Jan 17, 2017
HajkD added a commit that referenced this issue Jan 17, 2017
HajkD added a commit that referenced this issue Jan 17, 2017
HajkD added a commit that referenced this issue Jan 17, 2017
@HajkD
Copy link
Member

HajkD commented Jan 17, 2017

Hi Xin,

I just fixed the problem.

Please find all news here: https://github.com/HajkD/biomartr/blob/master/NEWS.md#bug-fixes

I now fixed all affected functions: getSummaryFile(), getKingdomAssemblySummary(), getMetaGenomeSummary(), getENSEMBL.Seq() and getENSEMBLGENOMES.Seq().

I will submit the new version of biomartr to CRAN in one or two weeks. But you can already install via devtools from github.

Again, many thanks for your help. I appreciate it a lot!

@HajkD HajkD closed this as completed Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants