Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix PersonProvider for en_GB #63

Closed
sckott opened this issue Feb 22, 2018 · 0 comments · Fixed by #75
Closed

fix PersonProvider for en_GB #63

sckott opened this issue Feb 22, 2018 · 0 comments · Fixed by #75
Milestone
v0.2

Comments

@sckott
Copy link
Collaborator

sckott commented Feb 22, 2018

last names for en_GB have probabilities. Is easy enough for a last_name function on the class to get last names, but need to fix $person() method
@sckott sckott added this to the v0.2 milestone Feb 23, 2018
kylevoyto added a commit to kylevoyto/charlatan that referenced this issue May 10, 2018
@kylevoyto
ropensci#63 - fix PersonProvider for en_GB.
ca67b2b 
The render function can now handle last names with probabilities.
Person formats for en_GB has also been updated in line with the other locales.
@kylevoyto kylevoyto mentioned this issue May 11, 2018
Merged
sckott added a commit that referenced this issue May 11, 2018
@sckott
Merge pull request #75 from kylevoyto/issue63
1d20338 
#63 - fix PersonProvider for en_GB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging a pull request may close this issue.

#63 - fix PersonProvider for en_GB. kylevoyto/charlatan
1 participant
@sckott