Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missingArg correction in windrose function #21

Closed
swmpkim opened this issue Jan 4, 2019 · 2 comments
Closed

missingArg correction in windrose function #21

swmpkim opened this issue Jan 4, 2019 · 2 comments

Comments

@swmpkim
Copy link

swmpkim commented Jan 4, 2019

Line 103 of cfData-plotMethods.R (the beginning of windrose ) should say:

if (missingArg(speed))

rather than:

  if (missingArg(direction))
    stop("speed can't be missing")

  if (missingArg(direction))
    stop("direction can't be missing")
@swmpkim
Copy link
Author

swmpkim commented Jan 4, 2019

I doubt this is worth a separate issue, but if you're modifying windrose for the above issue, there's also a minor typo on line 124; to be consistent with line 127 just add an 's' to speed:
stop("wind speeds need to be numeric")

I'm looking at this function so closely because I'm trying to improve functions that I write, and I've always liked making windroses from clifro. It's a really useful and well-written function; thanks!

@blasee
Copy link
Contributor

blasee commented Jan 8, 2019

Thanks @swmpkim!

blasee added a commit that referenced this issue Jan 8, 2019
@blasee blasee closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants