Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document internet requirements and add verbosity about internet… #275

Merged
merged 10 commits into from Jan 8, 2020
Merged

document internet requirements and add verbosity about internet… #275

merged 10 commits into from Jan 8, 2020

Conversation

maelle
Copy link
Member

@maelle maelle commented Dec 12, 2019

cf #270 cc @Bisaloo

@maelle
Copy link
Member Author

maelle commented Dec 19, 2019

@Bisaloo now you can see where the firewall blocks you ;-) (any feedback welcome, thanks again for the idea!)

@maelle maelle requested a review from cboettig December 19, 2019 20:33
@maelle maelle changed the title document internet requirements document internet requirements and add verbosity about internet stuff Dec 19, 2019
@maelle maelle added this to the 0.1.9 milestone Jan 6, 2020
cboettig
cboettig approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@cboettig cboettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Really like the verbosity toggle and improved documentation / messaging interface.

@maelle maelle changed the title document internet requirements and add verbosity about internet stuff document internet requirements and add verbosity about internet… Jan 8, 2020
@maelle maelle merged commit b3c39a8 into dev Jan 8, 2020
@maelle maelle deleted the internet branch January 8, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cboettig cboettig cboettig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maelle @cboettig