fix error, that B4 classification was wrongly coded under services in…

…stead of goods

R/ct_check_params.R

@@ -189,8 +189,8 @@ check_freq <- function(type, frequency) {
 #'
 #' @noRd
 check_clCode <- function(type,commodity_classification) {
-  cmd_list_goods <- c('HS','S1','S2','S3','S4','SS')
-  cmd_list_services <- c('B4','B5','EB02','EB10','EB10S','EB')
+  cmd_list_goods <- c('HS','S1','S2','S3','S4','SS',"B4","B5")
+  cmd_list_services <- c('EB02','EB10','EB10S','EB')
   if(type == 'C'){
     rlang::arg_match(commodity_classification, values = cmd_list_goods)
   } else {

R/ct_get_data.R

@@ -17,7 +17,7 @@
 #'
 #' @param frequency The frequency of returned trade data. Possible values: 'A' for annual data, 'M' for monthly data. Default: 'A'.
 #' @param type The type of returned trade data. Possible values: 'goods' for trade in goods, 'services' for trade in services. Default: 'goods'.
-#' @param commodity_classification The trade classification scheme. Possible values for goods: `c('HS','S1','S2','S3','S4','SS')`; for services: `c('B4','B5','EB02','EB10','EB10S','EB')`. Default: 'HS'.
+#' @param commodity_classification The trade classification scheme. Possible values for goods: `c('HS','S1','S2','S3','S4','SS','B4','B5')`; for services: `c('EB02','EB10','EB10S','EB')`. Default: 'HS'.
 #' @param commodity_code The commodity code(s) or `NULL`. See `comtradr::ct_get_ref_table('HS')` for possible values. Default: 'TOTAL' (sum of all commodities).
 #' @param flow_direction The direction of trade flows or `NULL`. Possible values: 'import', 'export', 're-import', 're-export', 'all'. Default: 'all'.
 #' @param reporter Reporter ISO3 code(s) or `NULL`. See `comtradr::country_codes` for possible values. Default: 'all'.

tests/testthat/test-ct_check_parameters.R

@@ -17,7 +17,7 @@ test_that("check_freq returns correct frequency codes and handles invalid inputs
 # Test 'check_clCode' function
 test_that("check_clCode returns correct classification codes and handles invalid inputs", {
   expect_equal(check_clCode("C", "HS"), "HS")
-  expect_equal(check_clCode("S", "B4"), "B4")
+  expect_equal(check_clCode("C", "B4"), "B4")
   expect_error(check_clCode("C", "ISIC"), "`commodity_classification` must be one of")
   expect_error(check_clCode("S", "HS"), "`commodity_classification` must be one of")
 })