update vignette and tests to reflect accepted changes with NULL VALUES

ropensci · Jul 31, 2023 · 86d9d1d · 86d9d1d
1 parent 849cba1
commit 86d9d1d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 24 deletions.
diff --git a/man/ct_commodity_lookup.Rd b/man/ct_commodity_lookup.Rd
diff --git a/man/ct_get_data.Rd b/man/ct_get_data.Rd
diff --git a/tests/testthat/test-ct_check_parameters.R b/tests/testthat/test-ct_check_parameters.R
@@ -31,7 +31,7 @@ test_that("check_flowCode returns correct flow codes and handles invalid inputs"
   expect_equal(check_flowCode("import"), "M")
   expect_equal(check_flowCode(c("export", "re-export")), "X,RX")
   expect_error(check_flowCode("trade"), "`flow_direction` must be one of")
-  expect_error(check_flowCode(NULL), "`flow_direction` must be a character vector, not `NULL`")
+  # expect_error(check_flowCode(NULL), "`flow_direction` must be a character vector, not `NULL`")
   expect_error(check_flowCode(c("all", "import")), "You can only provide 'all' as a single argument.")
 })
 
@@ -65,14 +65,14 @@ testthat::test_that("check_cmdCode function works correctly", {
     )
   )
 
-  testthat::expect_error(
-    comtradr:::check_cmdCode(
-      commodity_classification = "HS",
-      commodity_code = NULL,
-      update = FALSE,
-      verbose = FALSE
-    )
-  )
+  # testthat::expect_error(
+  #   comtradr:::check_cmdCode(
+  #     commodity_classification = "HS",
+  #     commodity_code = NULL,
+  #     update = FALSE,
+  #     verbose = FALSE
+  #   )
+  # )
 })
 
 testthat::test_that("check_reporterCode function works correctly", {
@@ -102,11 +102,6 @@ testthat::test_that("check_reporterCode function works correctly", {
     )
   ) > 0)
 
-  testthat::expect_error(comtradr:::check_reporterCode(
-    reporter = NULL,
-    update = FALSE,
-    verbose = FALSE
-  ))
 })