Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to R Packages book #498

Merged
merged 4 commits into from
Aug 8, 2022
Merged

Fix link to R Packages book #498

merged 4 commits into from
Aug 8, 2022

Conversation

fkohrt
Copy link
Contributor

@fkohrt fkohrt commented Aug 6, 2022

No description provided.

Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fkohrt , can you please just put " code.html" in lower case?

Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@fkohrt
Copy link
Contributor Author

fkohrt commented Aug 6, 2022

But I'm not sure if lowercase is best, because the original file name is Code.html (with the source named Code.Rmd) and IMHO the redirection code.htmlCode.html is done by Netlify (where "R Packages" is hosted). So you are relying on a platform-specific feature here.

But correct me if I'm wrong.

@mpadge
Copy link
Member

mpadge commented Aug 6, 2022

Oh sorry, i just tried "code.html" manually, and didn't see a re-direct. Can you then please run the {urlchecker} package on it, to get the correct version and update if needed?

@fkohrt
Copy link
Contributor Author

fkohrt commented Aug 6, 2022

Sorry, my previous comment was technically not correct:

Netlify makes the file available under both names, so no HTTP redirects are happening (and thus, {urlchecker} doesn't care). Still, I believe the original file name is the best choice in case Netlify is ever replaced by a different host.er

@fkohrt
Copy link
Contributor Author

fkohrt commented Aug 6, 2022

So, with your approval I will revert bfced34

See discussion at ropensci#498
@fkohrt
Copy link
Contributor Author

fkohrt commented Aug 7, 2022

@mpadge This can be merged.

@mpadge
Copy link
Member

mpadge commented Aug 8, 2022

Thanks @fkohrt, can you please just add a line to the changelog, and reference this PR? I'll merge then. Thank you.

@mpadge mpadge merged commit bba3697 into ropensci:main Aug 8, 2022
@fkohrt fkohrt deleted the patch-1 branch August 8, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants