Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to document defaults #501

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Aug 23, 2022

Fix #439

@mpadge mpadge requested review from mpadge and maelle August 23, 2022 12:46
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hugo!

@maelle
Copy link
Member

maelle commented Aug 23, 2022

Merci !!

Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update booknews.Rmd? Thank you!

@maelle maelle merged commit d5583f1 into ropensci:main Aug 23, 2022
@maelle
Copy link
Member

maelle commented Aug 23, 2022

Thank you!!

@Bisaloo Bisaloo deleted the document-defaults branch August 23, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend / mandate that all defaults are clearly documented
3 participants